Patch to bring back "open in new tab" option

Anonymous (not verified) —Tue, 05/12/2009 - 20:25

At some point I upgraded and the options to open in a new tab and open in a background tab disappeared. There is now a "Firefox" submenu, but I used these so often it wasn't working very well for me.

I don't know if this is the right place, but I'd like to put in a feature request to reinstate these options - and it seems I'm not alone judging by other posts on here.

To get the ball rolling, I'm including a small diff to add the "Open in New Tab" option back since this is the one I used the most. It would be trivial to add the "Open in Background Tab" option too, but I'm hoping these changes will get made upstream.

If there is a more appropriate place to post feature requests and/or patches, my apologies.

diff -r 9a9eec25a600 -r b7b5a043e776 chrome/content/overlay.xul --- a/chrome/content/overlay.xul Tue May 12 23:48:25 2009 +0100 +++ b/chrome/content/overlay.xul Wed May 13 00:57:02 2009 +0100 @@ -8,6 +8,7 @@


+      
@@ -178,6 +179,7 @@
           FdDom.get("fd-open-all").hidden = !thumbnail ||
                        !thumbnail.properties.isFolder || thumbnail.properties.isBack;
+          FdDom.get("fd-open-tab").hidden = !thumbnail || thumbnail.properties.isBack;
           FdDom.get("fd-refresh").hidden = !thumbnail || thumbnail.properties.isBack;
           FdDom.get("fd-remove").hidden = isReadOnly;
           FdDom.get("fd-separator2").hidden = isReadOnly;
@@ -191,6 +193,7 @@
           switch(command) {
             case "fd-open-all"   : thumbnail.openAll(); break;
+            case "fd-open-tab"   : thumbnail.openTab(); break;
             case "fd-refresh"    : thumbnail.refresh(); break;
             case "fd-remove"     : thumbnail.remove(true); break;
             case "fd-preferences": Fd.openPreferences(); break;
diff -r 9a9eec25a600 -r b7b5a043e776 chrome/content/thumbnail/thumbnail.js

--- a/chrome/content/thumbnail/thumbnail.js	Tue May 12 23:48:25 2009 +0100

+++ b/chrome/content/thumbnail/thumbnail.js	Wed May 13 00:57:02 2009 +0100

@@ -65,6 +65,10 @@ function FdThumbnail(properties) {

     }
   }
+  this.openTab = function() {
+      FdUtils.openLink(this.getURL(), "tabshifted");
+  }
+
   function confirmRemove() {
     var title = this.properties.title;
     var message = FdBundle.getString("remove", [title]);
diff -r 9a9eec25a600 -r b7b5a043e776 chrome/locale/en-US/fastdial.dtd

--- a/chrome/locale/en-US/fastdial.dtd	Tue May 12 23:48:25 2009 +0100

+++ b/chrome/locale/en-US/fastdial.dtd	Wed May 13 00:57:02 2009 +0100

@@ -6,6 +6,7 @@
+

Fast Dial

Log in or register to post comments or vote.
0
0 votes

Online users

There are currently 0 users online.
Active - 15 mins:

No registered users :(

Top contributors

User	Total user points
Mafia_Penguin	912
Deva	552
gumanov	490
jumpordie	471
Karmody	457
macleod.mac	402
ingalls	354
spaljeni	310
zigzag	290
Rog	265
Sastre	256
famecky	160
x-b	152
danger83	147
1air2philou	143

Error message